Update session log with grooming pass details

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-03-29 15:33:37 +11:00
parent 87249b6d9b
commit d66c59c56b

View File

@@ -26,6 +26,35 @@ Each entry follows this structure:
## Sessions
### Session 2026-03-29c — Grooming pass: critique/harden/polish all 15 steps
**Agent(s):** Claude Opus 4.6 (1M context)
**Work completed:**
- **Full grooming pass across all 15 wizard steps** — applied critique (UX design review), harden (edge cases/error states), and polish (visual alignment/copy/code) frameworks.
- **[P0] CrematoriumStep bug fix:** `<option>` elements replaced with `<MenuItem>` — the MUI `<TextField select>` requires MenuItem children, not native option elements. The priority dropdown was non-functional.
- **[P1] Double-submit prevention:** Added `if (!loading) onContinue()` guard to all form `onSubmit` handlers across steps 1, 5, 6, 7, 8, 9, 10, 11, 12, 14 (10 steps with forms). Prevents keyboard Enter re-submission during async loading.
- **[P1] Accessibility — aria-busy:** Added `aria-busy={loading}` to all form elements so screen readers announce processing state.
- **[P1] Error colour normalisation:** Replaced `color="error"` (red #BC2F2F) with `var(--fa-color-text-brand)` (copper #B0610F) across 7 steps (ProvidersStep, PackagesStep, VenueStep, CrematoriumStep, CemeteryStep, CoffinsStep, PaymentStep). Per D024, FA uses warm copper for errors rather than aggressive red.
- **[P2] Grief-sensitive copy:** "Has the person died?" → "Has this person passed away?" (IntroStep). "About the person who died" → "About the person who has passed" (DateTimeStep).
- **[P2] Results count copy:** "Showing results from X providers" → "X providers found" (ProvidersStep).
- **[P2] Empty state guidance:** Added actionable guidance text to empty states in ProvidersStep, PackagesStep, VenueStep, CoffinsStep ("Try adjusting..." copy).
- **Steps that passed with no issues:** PreviewStep (4), SummaryStep (13), ConfirmationStep (15) — all clean.
- **IntroStep critique score: 35/40 (Good)** — full heuristic scoring completed as reference.
**Decisions made:**
- Error text colour standardised on `var(--fa-color-text-brand)` (copper) for all wizard step error messages — consistent with D024's principle of gentle error feedback. Atom-level error styling (ToggleButtonGroup, TextField) still uses MUI's error.main; that's an atom concern for a separate pass.
**Open questions:**
- ToggleButtonGroup and TextField atoms still use `error.main` (red) for their built-in error borders. Should these be changed to copper at the atom level? (Would affect all consumers, not just wizard steps.)
**Next steps:**
- Retroactive review backlog: Phase 2.2 (molecule audits), Phase 3 (organisms), Phase 4 (cross-cutting)
- Integration: routing, state management, GraphQL queries
- Consider atom-level error colour update (ToggleButtonGroup, TextField)
---
### Session 2026-03-29b — Wizard steps 5-15 (complete flow)
**Agent(s):** Claude Opus 4.6 (1M context)