richie/Parsons
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update session log, mark D034 resolved, document roadmap

Browse Source 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Richie
2026-03-29 15:50:41 +11:00
parent 884e79c0d2
commit 595ca33779
2 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
docs/memory/decisions-log.md
View File

@@ -278,13 +278,12 @@ contradict a previous one.
**Affects:** FuneralFinder stories (title changes), component-registry (V3 = done, V1/V2 = archived), retroactive review (only V3 gets full treatment) **Affects:** FuneralFinder stories (title changes), component-registry (V3 = done, V1/V2 = archived), retroactive review (only V3 gets full treatment)
**Alternatives considered:** Deleting V1/V2 — rejected because user needs them for client walkthroughs. **Alternatives considered:** Deleting V1/V2 — rejected because user needs them for client walkthroughs.
### D034 — Form error styling should use copper, not red (pending) ### D034 — Form error styling uses copper, not red
**Date:** 2026-03-29 **Date:** 2026-03-29
**Category:** token **Category:** token
**Decision:** Pending — form error borders and helper text should use copper (#B0610F) instead of MUI's default red (#BC2F2F). Page-level error messages already use copper as of the grooming pass. Atom-level styling (ToggleButtonGroup error border, TextField/OutlinedInput error border, FormHelperText) still uses `palette.error.main` (red). **Decision:** Form error borders and helper text use copper (#B0610F / ColorTextBrand) instead of MUI's default red (#BC2F2F). `palette.error.main` remains red for non-form uses (destructive buttons, system alerts).
**Rationale:** FA's grief-sensitive context makes aggressive red inappropriate for form validation. D024 established that labels stay neutral on error; extending this principle to borders and helper text creates a fully warm error experience. Page-level error messages already use `var(--fa-color-text-brand)` (copper) — atom-level should match. **Rationale:** FA's grief-sensitive context makes aggressive red inappropriate for form validation. D024 established labels stay neutral on error; D034 extends this to borders and helper text for a fully warm error experience. Copper at 4.8:1 contrast on white meets WCAG AA.
**Recommended approach:** Override `MuiFormHelperText`, `MuiOutlinedInput`, and ToggleButtonGroup error styles in the MUI theme to use copper. Keep `palette.error.main` red for non-form uses (destructive buttons, system alerts). **Affects:** src/theme/index.ts (MuiOutlinedInput, MuiFormHelperText, MuiFormLabel overrides), ToggleButtonGroup atom, all page-level error Typography elements
**Affects:** src/theme/index.ts, ToggleButtonGroup atom, all form-consuming components
**Alternatives considered:** Changing `palette.error.main` globally to copper — rejected because destructive action buttons and system alerts may genuinely need red. **Alternatives considered:** Changing `palette.error.main` globally to copper — rejected because destructive action buttons and system alerts may genuinely need red.
### D033 — Retroactive review uses P0/P1 only, interleaved with new work ### D033 — Retroactive review uses P0/P1 only, interleaved with new work

14
docs/memory/session-log.md
View File

@@ -41,17 +41,21 @@ Each entry follows this structure:
- **[P2] Empty state guidance:** Added actionable guidance text to empty states in ProvidersStep, PackagesStep, VenueStep, CoffinsStep ("Try adjusting..." copy). - **[P2] Empty state guidance:** Added actionable guidance text to empty states in ProvidersStep, PackagesStep, VenueStep, CoffinsStep ("Try adjusting..." copy).
- **Steps that passed with no issues:** PreviewStep (4), SummaryStep (13), ConfirmationStep (15) — all clean. - **Steps that passed with no issues:** PreviewStep (4), SummaryStep (13), ConfirmationStep (15) — all clean.
- **IntroStep critique score: 35/40 (Good)** — full heuristic scoring completed as reference. - **IntroStep critique score: 35/40 (Good)** — full heuristic scoring completed as reference.
- **D034 implemented:** Form error styling unified to copper end-to-end. MuiOutlinedInput error border/ring, MuiFormHelperText error text, MuiFormLabel error state (neutral per D024), ToggleButtonGroup error border — all now use copper (#B0610F). `palette.error.main` remains red for non-form uses.
- **Tagged `v0.1-wizard-groomed`** — safe rollback point before user review checkpoint.
- **Roadmap documented** in persistent memory (`project_roadmap.md`) with 9 phases, checkpoint gates, and guiding principles.
**Decisions made:** **Decisions made:**
- Error text colour standardised on `var(--fa-color-text-brand)` (copper) for all wizard step error messages — consistent with D024's principle of gentle error feedback. Atom-level error styling (ToggleButtonGroup, TextField) still uses MUI's error.main; that's an atom concern for a separate pass. - D034: Form error styling uses copper across theme (MuiOutlinedInput, MuiFormHelperText, MuiFormLabel, ToggleButtonGroup). `palette.error.main` stays red for destructive buttons/system alerts.
- User review checkpoint required before integration — tagged `v0.1-wizard-groomed` as rollback point.
**Open questions:** **Open questions:**
- ToggleButtonGroup and TextField atoms still use `error.main` (red) for their built-in error borders. Should these be changed to copper at the atom level? (Would affect all consumers, not just wizard steps.) - None
**Next steps:** **Next steps:**
- Retroactive review backlog: Phase 2.2 (molecule audits), Phase 3 (organisms), Phase 4 (cross-cutting) - **Phase 4: User review checkpoint** — user reviews all 15 steps in Storybook, provides feedback, agent iterates
- Integration: routing, state management, GraphQL queries - Phase 5: Retroactive review backlog (can interleave with Phase 4)
- Consider atom-level error colour update (ToggleButtonGroup, TextField) - Phase 6: Integration planning (after checkpoint resolved)
--- ---