Update session log and retroactive review plan for 2026-03-30d
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -49,11 +49,18 @@ Each entry follows this structure:
|
||||
- **aria-describedby/aria-invalid:** All wizard steps lack error field association. Batch normalize fix recommended.
|
||||
- **Retroactive review Phase 2.2** still pending (audit priority molecules: ServiceOption, AddOnOption, ProviderCardCompact)
|
||||
|
||||
**Also completed (same session):**
|
||||
- **Checkbox atom created:** New FA wrapper (forwardRef, displayName, stories: Default/States/TermsAgreement/Checklist). MuiCheckbox theme overrides (warm gold checked, focus ring, disabled muted). PaymentStep updated to import from atom.
|
||||
- **Retroactive review Phase 2.2 complete:** Audited ServiceOption (13/20), AddOnOption (14/20), ProviderCardCompact (15/20). Fixed:
|
||||
- AddOnOption: added `aria-disabled` when disabled (P1)
|
||||
- ProviderCardCompact: added `maxLines={1}` on name (P2)
|
||||
- ServiceOption: price uses `labelLg` variant instead of h6 + hardcoded fontWeight (P1)
|
||||
- Note: audit agents flagged false P0s (AddOnOption "double handler", ServiceOption "role collision") — verified both are correctly handled by existing `stopPropagation` and prop spread order in Card atom
|
||||
|
||||
**Next steps:**
|
||||
- Batch a11y fix: add aria-describedby + aria-invalid to error fields across all wizard steps
|
||||
- Create Checkbox atom if prioritised
|
||||
- Retroactive review Phase 2.2 (morning housekeeping)
|
||||
- Continue any further page-specific feedback from user review
|
||||
- User has step page feedback to provide — iterate when ready
|
||||
- Batch a11y fix: add aria-describedby + aria-invalid to error fields across all wizard steps (deferred per user)
|
||||
- Retroactive review Phase 3: organisms normalize + audit (Navigation, ServiceSelector, FuneralFinderV3)
|
||||
|
||||
---
|
||||
|
||||
|
||||
@@ -62,11 +62,11 @@ Run `/audit` and `/critique` on molecules with real layout complexity.
|
||||
| ProviderCard | Critique 33/40 (v2 iteration) | Medium (user-approved) |
|
||||
| VenueCard | Critique 33/40 | Medium (user-approved) |
|
||||
| SearchBar | Critique 35/40 | Low (high scores already) |
|
||||
| ServiceOption | — | Medium (used by ServiceSelector) |
|
||||
| AddOnOption | — | Medium (similar pattern to ServiceOption) |
|
||||
| ServiceOption | **Audit 13/20** (2026-03-30, P1 fixed) | ~~Medium~~ Done |
|
||||
| AddOnOption | **Audit 14/20** (2026-03-30, P1 fixed) | ~~Medium~~ Done |
|
||||
| StepIndicator | — | Low (display-only) |
|
||||
| LineItem | Audit 19/20 | Low (excellent score) |
|
||||
| ProviderCardCompact | — | Medium (newer, less reviewed) |
|
||||
| ProviderCardCompact | **Audit 15/20** (2026-03-30, P2 fixed) | ~~Medium~~ Done |
|
||||
|
||||
**Estimated effort:** 1 session for normalize + audit of medium priority molecules.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user